Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"add-cover" edits in Recent Changes table should display Cover as comment (for review) #29

Closed
george08 opened this issue Jun 29, 2011 · 11 comments · Fixed by #5716
Closed

"add-cover" edits in Recent Changes table should display Cover as comment (for review) #29

george08 opened this issue Jun 29, 2011 · 11 comments · Fixed by #5716
Labels
Affects: UI Issues with the web site's user interface. [managed] Good First Issue Easy issue. Good for newcomers. [managed] hacktoberfest Issues appropriate for Hacktoberfest participants Module: Cover Service Cover Store (book covers service) Priority: 3 Issues that we can consider at our leisure. [managed] Team: Front-end Issues belonging to the Front-end team [experimental tag] Theme: Editing Issues related to the user editing/wiki editing experience. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
Hacktoberfest Triage
Milestone
Hacktoberfest

Comments

@george08
Copy link

It would be very useful to review new covers uploaded to watch for spam.

So, in entries where add-cover is used, like all these - http://openlibrary.org/recentchanges/add-cover - let's start displaying the actual cover as the comment.
@ghost ghost assigned anandology Jun 29, 2011
@george08
Copy link
Author

Just like they display here: http://openlibrary.org/works/OL1248930W/A_history_of_England_from_the_coming_of_the_English_to_1918?m=diff&b=3

@anandology
Copy link
Collaborator

Can't finish it in July. Moving it to August.

@anandology
Copy link
Collaborator

Moved to september milestone.

@mekarpeles mekarpeles changed the title add-cover should display covers "add-cover" edits in Recent Changes table should display Cover as comment (for review) Mar 21, 2018
@mekarpeles mekarpeles added Module: Cover Service Cover Store (book covers service) Good First Issue Easy issue. Good for newcomers. [managed] Theme: Editing Issues related to the user editing/wiki editing experience. [managed] labels Mar 21, 2018
@sbshah97 sbshah97 added the hacktoberfest Issues appropriate for Hacktoberfest participants label Sep 24, 2018
@kryptc
Copy link

kryptc commented Oct 13, 2018

Hi, can I work on this issue?

@mekarpeles
Copy link
Member

Sure! We'd love that @kryptc!

@sbshah97
Copy link
Contributor

@kryptc do let us know in case we can help you out if you're stuck

@kryptc
Copy link

kryptc commented Oct 18, 2018

Sorry for the delay, I was having some trouble installing docker on my system

@kryptc
Copy link

kryptc commented Oct 24, 2018

Hi, I had a question regarding where the file corresponding to the add-cover section is. In the recentchanges directory in templates, there is no add-cover directory. Where do I make the changes?

@rohitjain00
Copy link
Contributor

@kryptc I think you need to ask these kind of questions on Slack or Gitter. There you will find the help you needed.

@rohitjain00 rohitjain00 mentioned this issue Mar 22, 2019
Closed
@mekarpeles
Copy link
Member

@kryptc can we send you an invitation to our slack channel?

@mekarpeles mekarpeles removed their assignment May 14, 2019
@tabshaikh tabshaikh added this to To do in Hacktoberfest Sep 25, 2019
@xayhewalo xayhewalo added this to Un-Triaged in Triage Oct 20, 2019
@xayhewalo xayhewalo added State: Backlogged Affects: UI Issues with the web site's user interface. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Nov 22, 2019
@xayhewalo xayhewalo moved this from Un-Triaged to Needs: Assessment in Triage Nov 22, 2019
@mekarpeles mekarpeles added Needs: Lead and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Apr 20, 2020
@mekarpeles mekarpeles added Team: Front-end Issues belonging to the Front-end team [experimental tag] and removed frontend labels Jan 23, 2021
@tushar-ga
Copy link

Hey, Can I work on this issue?

@Yashs911 Yashs911 mentioned this issue Oct 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Affects: UI Issues with the web site's user interface. [managed] Good First Issue Easy issue. Good for newcomers. [managed] hacktoberfest Issues appropriate for Hacktoberfest participants Module: Cover Service Cover Store (book covers service) Priority: 3 Issues that we can consider at our leisure. [managed] Team: Front-end Issues belonging to the Front-end team [experimental tag] Theme: Editing Issues related to the user editing/wiki editing experience. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
No open projects
Hacktoberfest
  
To do
Triage
  
Needs: Assessment
Milestone
Hacktoberfest
Development

Successfully merging a pull request may close this issue.

Display cover as comment in Recent Changes Table Yashs911/openlibrary
9 participants
@anandology @george08 @mekarpeles @xayhewalo @sbshah97 @rohitjain00 @tabshaikh @kryptc @tushar-ga