Add rebind_interval #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looneym
force-pushed
the
ml/rebind-interval
branch
2 times, most recently
from
c065293
to
769b96b
Compare
looneym
force-pushed
the
ml/rebind-interval
branch
from
769b96b
to
c3797f5
Compare
looneym
commented
Apr 18, 2024
lib/fluent/plugin/out_logstash.rb
Outdated
| retry | ||
| end | ||
| raise ConnectionFailure, "Could not push logs to logstash after #{retries} retries, #{e.message}" | ||
| @mutex.synchronize { |
There was a problem hiding this comment.
Since client is only ever called from send_to_logstash, perhaps the double mutex is unnecessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.