visualizer framework fix (#2014)

* visualizer framework fix * fix test * fix * fix
intelowlproject · Dec 7, 2023 · 4bdc711 · 4bdc711
1 parent e96f180
commit 4bdc711
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/api_app/classes.py b/api_app/classes.py
@@ -267,4 +267,4 @@ def health_check(self, user: User = None) -> bool:
                     return False
                 else:
                     return True
-        raise NotImplementedError("No healthcheck implemented")
+        raise NotImplementedError()
diff --git a/api_app/views.py b/api_app/views.py
@@ -877,7 +877,7 @@ def health_check(self, request, pk=None):
             health_status = python_obj.health_check(request.user)
         except NotImplementedError as e:
             logger.info(f"NotImplementedError {e}, user {request.user}, name {pk}")
-            raise ValidationError({"detail": "Not implemented"})
+            raise ValidationError({"detail": "No healthcheck implemented"})
         except Exception as e:
             logger.exception(e)
             raise ValidationError(

diff --git a/api_app/visualizers_manager/classes.py b/api_app/visualizers_manager/classes.py
@@ -115,7 +115,7 @@ class VisualizableTitle(VisualizableObject):
     def __init__(
         self,
         title: VisualizableBase,
-        value: VisualizableBase,
+        value: VisualizableObject,
         alignment: VisualizableAlignment = VisualizableAlignment.CENTER,
         size: VisualizableSize = VisualizableSize.S_AUTO,
         disable: bool = True,

diff --git a/frontend/src/components/jobs/result/visualizer/elements/base.jsx b/frontend/src/components/jobs/result/visualizer/elements/base.jsx
@@ -41,7 +41,7 @@ export function BaseVisualizer({
     <div
       className={`${size} ${
         isChild ? "small" : ""
-      } p-1 d-flex align-items-center text-${alignment} justify-content-${alignment} ${
+      } p-0 m-1 d-flex align-items-center text-${alignment} justify-content-${alignment} ${
         disable ? "opacity-25" : ""
       } ${color}`}
       id={id}

diff --git a/frontend/tests/components/jobs/result/visualizer/elements/base.test.jsx b/frontend/tests/components/jobs/result/visualizer/elements/base.test.jsx
@@ -35,7 +35,7 @@ describe("BaseVisualizer component", () => {
     // check size and alignment
     const outerPartComponent = innerPartComponent.closest("div");
     expect(outerPartComponent.className).toBe(
-      "col-1  p-1 d-flex align-items-center text-center justify-content-center  ",
+      "col-1  p-0 m-1 d-flex align-items-center text-center justify-content-center  ",
     );
     // check tooltip
     const user = userEvent.setup();
@@ -84,7 +84,7 @@ describe("BaseVisualizer component", () => {
     );
     // check optional elements (like bold, italic...)
     expect(idElement.className).toBe(
-      "col-2 small p-1 d-flex align-items-center text-start justify-content-start  success",
+      "col-2 small p-0 m-1 d-flex align-items-center text-start justify-content-start  success",
     );
     // check tooltip
     const user = userEvent.setup();
@@ -133,7 +133,7 @@ describe("BaseVisualizer component", () => {
     // check optional elements (like bold, italic...)
     const outerPartComponent = innerPartComponent.closest("div");
     expect(outerPartComponent.className).toBe(
-      "col-2  p-1 d-flex align-items-center text-start justify-content-start opacity-25 success",
+      "col-2  p-0 m-1 d-flex align-items-center text-start justify-content-start opacity-25 success",
     );
   });
 });