Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More upgrades #812

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

More upgrades #812

wants to merge 9 commits into from

Conversation

cies
Copy link
Contributor

@cies cies commented Apr 10, 2024

It builds, but the test do not pass yet.

Somehow the number of tests increased drastically (from ~90 to ~300) compared to master, and now half of them fail.

This branch does upgrade the last not-current dependencies to current versions.

@cies cies self-assigned this Apr 10, 2024
Copy link

github-actions bot commented Apr 11, 2024

Qodana Community for JVM

186 new problems were found

Inspection name Severity Problems
Unstable API Usage 🔴 Failure 1
Unused symbol 🔶 Warning 46
Incorrect string capitalization 🔶 Warning 18
Constant conditions 🔶 Warning 13
Redundant nullable return type 🔶 Warning 11
Unresolved reference in KDoc 🔶 Warning 7
Unused import directive 🔶 Warning 6
Unstable API Usage 🔶 Warning 4
Inconsistent comment for Java parameter 🔶 Warning 3
Redundant qualifier name 🔶 Warning 3
Usage of redundant or deprecated syntax or deprecated symbols 🔶 Warning 1
Multiple operators with different precedence 🔶 Warning 1
Boolean literal argument without parameter name ◽️ Notice 18
Class member can have 'private' visibility ◽️ Notice 12
Accessor call that can be replaced with property access syntax ◽️ Notice 6
Might be 'const' ◽️ Notice 5
Nested lambda has shadowed implicit parameter ◽️ Notice 5
Unnecessary type argument ◽️ Notice 4
Function or property has platform type ◽️ Notice 3
Private property naming convention ◽️ Notice 3
'when' that can be simplified by introducing an argument ◽️ Notice 2
Constant conditions ◽️ Notice 2
Return or assignment can be lifted out ◽️ Notice 2
Cascade 'if' can be replaced with 'when' ◽️ Notice 1
@Deprecated annotation without 'replaceWith' argument ◽️ Notice 1
Lambda argument inside parentheses ◽️ Notice 1
Variable declaration could be moved inside 'when' ◽️ Notice 1
Object literal can be converted to lambda ◽️ Notice 1
Redundant 'constructor' keyword ◽️ Notice 1
Redundant 'if' statement ◽️ Notice 1
Range can be converted to indices or iteration ◽️ Notice 1
Call chain on collection type can be simplified ◽️ Notice 1
Augmented assignment creates a new collection under the hood ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@cies cies modified the milestone: 5.0.1 Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant