Don't require Lamdera during project setup #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the work, I can confirm that it works (checked with IntelliJ IDEA 2022.2.4 (Community Edition))! |
|
Already not good enough for IDEA 2022.3.3
update pluginUntilBuild property in gradle.properties. |
|
I'm going to merge this. LGTM. |
|
@JEphron Could you merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it's nice to make accommodations for users who use the Lamdera platform, the primary purpose of this plugin is support for the Elm language. Most likely the majority of users have never even heard of Lamdera, and shouldn't be required to learn about it or install it to have support for Elm in their editor. :)
This PR also bumps the max Intellij version so that we can use this plugin in Intellij 2022.