Method extraction

[ishmum123]

No description provided.

[klazuka]

Thanks. This has the potential to be an awesome feature, and I like where you're going with it.

Please add some additional tests for more complex situations. I tried it out on an expression in elm-spa-example , and it generated bad code (it didn't extract a function parameter for maybeCred).

[ishmum123]

@klazuka hope the new job is going well. If you are too busy would you like to give me or @pravdomil write permission?

[klazuka]

I tried out your latest branch on elm-spa-example src/Page/Profile.elm. Attached is a video showing (1) how I perform ad-hoc testing of features like this to verify that it generates correct code and (2) shows several places where the method extraction does not work correctly (although I should say that in many cases it works well).

The main issues I found are:

1. bad code gen when the expression is nested in case expressions
2. one case where a value from the lexical scope did not have a function parameter (see video at 1:40)

These issues would need to be fixed before I would merge it. My basic criteria for any refactoring is that if the refactoring is offered by the plugin, then invoking the refactoring should always generate correct code.

Another small issue is that generated functions always have the name fn, even if one already exists. It'd be nice if it added a numeric suffix as needed.

method.extraction.mov

[ishmum123]

Thank you so much for the response. Would try to get it done ASAP.

[ishmum123]

@klazuka I think the current push fixes the issues you highlighted. Sorry for making you check so much... I would need to give some thought for making the enumerated fn. Please let me know if that is absolutely necessary

[ishmum123]

Here's a check with the exact examples you used... Can you please suggest something about the feed case?

Extract.Method.mov