idxd-config: use distroless:base as base #1715
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythi
reviewed
Apr 23, 2024
build/docker/templates/intel-idxd-config-initcontainer.Dockerfile.in
Outdated
Show resolved
Hide resolved
tkatila
force-pushed
the
idxd-config-base-change
branch
from
f1305a9
to
c2e425d
Compare
mythi
reviewed
Apr 24, 2024
| RUN apt-get update && apt-get install -y --no-install-recommends accel-config jq && rm -rf /var/lib/apt/lists/\* | ||
| RUN mkdir -p /idxd-init/scratch | ||
| ARG LIBS="libjson libaccel libjq libtinfo libonig libacl libselinux libpcre2-8" | ||
| ARG EXECS="bash env accel-config jq sed grep" |
There was a problem hiding this comment.
maybe worth thinking if it made sense to bring in toybox here too?
There was a problem hiding this comment.
Replacing the debian tools with toybox or just having toybox as it's convenient?
There was a problem hiding this comment.
replacing bash, env, sed and grep from Debian with toybox
tkatila
commented
Apr 24, 2024
Use toybox tools and adapt idxd-init.sh Signed-off-by: Tuomas Katila <tuomas.katila@intel.com>
Use toybox's tools and convert test_fpga to run on toybox sh Signed-off-by: Tuomas Katila <tuomas.katila@intel.com>
tkatila
force-pushed
the
idxd-config-base-change
branch
from
c2e425d
to
32ab52e
Compare
Signed-off-by: Tuomas Katila <tuomas.katila@intel.com>
tkatila
force-pushed
the
idxd-config-base-change
branch
from
32ab52e
to
2d21e71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.