Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add gpu_fakedev to the extensions list #1665

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hugo-syn
Copy link
Contributor

Add gpu_fakedev to the extensions list

Signed-off-by: hugo-syn <hugo.vincent@synacktiv.com>
@eero-t
Copy link
Contributor

eero-t commented Feb 12, 2024

@hugo-syn gpu_fakedev is GPU plugin testing tool (for trying it on nodes without the actual GPU HW, e.g. for scalability testing), so I'm not sure whether it belongs to plugins' end user documentation. Did you have some particular reason why it would be good to include to plugin extensions list?

@hugo-syn
Copy link
Contributor Author

Not particularly, it was not listed in the documentation I thought that users could use this for testing

@eero-t
Copy link
Contributor

eero-t commented Feb 13, 2024

@tkatila, what do you think, does it make sense to mention fakedev in extensions list doc?

@tkatila
Copy link
Contributor

tkatila commented Feb 13, 2024

Well, there are also items like "Intel FPGA test tool" in the extensions. So GPU fakedev would be fine in that sense. We're also missing the xpumanager-sidecar from the list.

@eero-t
Copy link
Contributor

eero-t commented Feb 13, 2024

Well, there are also items like "Intel FPGA test tool" in the extensions. So GPU fakedev would be fine in that sense.

Maybe there should be a separate testing tools list?

We're also missing the xpumanager-sidecar from the list.

Oh, that should definitely be in the extension list.

@tkatila
Copy link
Contributor

tkatila commented Feb 14, 2024

Well, there are also items like "Intel FPGA test tool" in the extensions. So GPU fakedev would be fine in that sense.

Maybe there should be a separate testing tools list?

I don't think that's necessary.

@hugo-syn can you also add xpu-manager-sidecar to the extensions list. Then I'm fine to merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants