This repository has been archived by the owner on May 9, 2024. It is now read-only.
[Fetch Data] Linearized buffer memory managment #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devjiu
force-pushed
the
dmitriim/buffer_fix
branch
from
bf7959b
to
4a0de96
Compare
Devjiu
changed the title
Devjiu
force-pushed
the
dmitriim/buffer_fix
branch
from
4a0de96
to
da62628
Compare
ienkovich
reviewed
Sep 29, 2023
| @@ -478,6 +481,18 @@ const int8_t* ColumnFetcher::linearizeColumnFragments( | |||
| // prepare ChunkIter for the linearized chunk | |||
| auto merged_chunk = std::make_shared<Chunk_NS::Chunk>( | |||
| merged_data_buffer, merged_index_buffer, col_info); | |||
| merged_data_buffer->deleteWhenUnpinned(); | |||
There was a problem hiding this comment.
It's enough to call this method once (in dtor).
There was a problem hiding this comment.
done, review again, please
Devjiu
force-pushed
the
dmitriim/buffer_fix
branch
from
da62628
to
62f0cb5
Compare
Devjiu
force-pushed
the
dmitriim/buffer_fix
branch
2 times, most recently
from
af91d3a
to
9070957
Compare
This commit removes freeLinearizedBuf() to avoid chunks that have references to deleted buffers. They will now be marked as deleted when unpinned. All buffers should now be removed via BufferManagers::free. Signed-off-by: Dmitrii Makarenko <dmitrii.makarenko@intel.com>
Devjiu
force-pushed
the
dmitriim/buffer_fix
branch
from
f820cbe
to
f28d59c
Compare
|
@alexbaden @kurapov-peter PTAL, this pr changes free method contract a little, and also changes interaction of buffer with bufferManager. It works, but perhaps you have some recommendations about method's visibility and class responsibilities. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes freeLinearizedBuf() to avoid chunks that have
references to deleted buffers. They will now be marked as deleted when
unpinned. All buffers should now be removed via BufferManagers::free.
Signed-off-by: Dmitrii Makarenko dmitrii.makarenko@intel.com