-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏳️ Custom properties resource & data #2107
base: main
Are you sure you want to change the base?
Conversation
d5be511
to
3432109
Compare
3432109
to
3011363
Compare
If I'm ready this correctly, this is only adding support to create/read custom properties definitions, would it also be possible to add support for defining custom properties values (by repo)? |
if err := resourceGithubCustomPropertiesCreate(d, meta); err != nil { | ||
return err | ||
} | ||
return resourceGithubTeamRead(d, meta) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you probably want to return the resourceGithubCustomPropertiesRead(d, meta) value, I guess this is a typo
I've looked a bit into it, and it should be possible once PR #2188 is merged to update go-github, since there was bug relating to that api that was fixed. I'm likely to try to build a working version of that feature on my side, i'll follow up there once it's done. |
Resolves #1956
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!