Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add --oidc-issuer-url-override options #1073

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kahirokunn
Copy link

@kahirokunn kahirokunn commented Apr 4, 2024

The domain to the k8s cluster and dex and the domain to the kubectl user and dex may be different.
For example: If you access dex from kubectl, use dex.example.com; if you access dex from a k8s cluster, use dex-internal.example.com.

To cope with this situation, gooidc's IssuerURLOverride option is available.

@kahirokunn kahirokunn force-pushed the override-iss branch 3 times, most recently from 02f6410 to b28db26 Compare April 4, 2024 02:51
@kahirokunn kahirokunn changed the title feat: add oidc-issuer-url-override flag feat: add --oidc-issuer-url-override flag Apr 4, 2024
@kahirokunn kahirokunn force-pushed the override-iss branch 2 times, most recently from 0afe16b to 9abb652 Compare April 5, 2024 05:29
@kahirokunn kahirokunn changed the title feat: add --oidc-issuer-url-override flag feat: Add --oidc-issuer-url-override options Apr 5, 2024
@kahirokunn
Copy link
Author

@int128 The content is just to pass IssuerURLOverride to gooidc.
Would you be willing to review it?
Thx 🙏

Signed-off-by: kahirokunn <okinakahiro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant