fix: configure csv writer's escape character to be an empty string by default #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dkarlovi WDYT? |
|
IMO, it's OK to allow this via config, but it's not a good default since it might break current use cases. I'd say we want this to be configurable. |
|
@slri can you make that configurable? |
|
@dpfaffenbauer i agree with the points and would have made it configurable from the get go if i had time for it. i'll do it over the weekend. |
|
Took a while to get to it, but it's finally done. |
|
fine by me @dkarlovi WDYT? |
dkarlovi
reviewed
Mar 8, 2023
dkarlovi
reviewed
Mar 8, 2023
src/DataDefinitionsBundle/Resources/public/pimcore/js/export_provider/csv.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates CsvProvider to set escape character as an empty string for the writer, see original issue.