Removed backend menu point and optimized if else condition in ICS tool

instride-ch · Oct 18, 2018 · 7ca144a · 7ca144a
1 parent 34f7ed4
commit 7ca144a
Show file tree

Hide file tree

Showing 11 changed files with 2 additions and 210 deletions.
diff --git a/src/Application/Version.php b/src/Application/Version.php
diff --git a/src/Controller/Admin/VersionController.php b/src/Controller/Admin/VersionController.php
diff --git a/src/Resources/config/pimcore/routing.yml b/src/Resources/config/pimcore/routing.yml
@@ -1,4 +0,0 @@
-# Get bundle version
-wvision.admin.version.get_version:
-  path: /admin/wvision/version/get-version
-  defaults: { _controller: WvisionBundle:Admin\Version:getVersion }

diff --git a/src/Resources/public/pimcore/css/bundle.css b/src/Resources/public/pimcore/css/bundle.css
diff --git a/src/Resources/public/pimcore/img/logo.svg b/src/Resources/public/pimcore/img/logo.svg
diff --git a/src/Resources/public/pimcore/img/wvision.svg b/src/Resources/public/pimcore/img/wvision.svg
diff --git a/src/Resources/public/pimcore/js/global.js b/src/Resources/public/pimcore/js/global.js
diff --git a/src/Resources/public/pimcore/js/wvision/helpers.js b/src/Resources/public/pimcore/js/wvision/helpers.js
diff --git a/src/Resources/translations/admin.de.yml b/src/Resources/translations/admin.de.yml
diff --git a/src/Resources/translations/admin.en.yml b/src/Resources/translations/admin.en.yml
diff --git a/src/Tool/Ics.php b/src/Tool/Ics.php
@@ -58,10 +58,8 @@ public function set($key, $val = false)
             foreach ($key as $k => $v) {
                 $this->set($k, $v);
             }
-        } else {
-            if (\in_array($key, self::$availableProperties, true)) {
-                $this->properties[$key] = $this->sanitizeVal($val, $key);
-            }
+        } else if (\in_array($key, self::$availableProperties, true)) {
+            $this->properties[$key] = $this->sanitizeVal($val, $key);
         }
     }