Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat : MultiCVRP wrapper #1043

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from
Open

Feat : MultiCVRP wrapper #1043

wants to merge 31 commits into from

Conversation

Louay-Ben-nessir
Copy link
Contributor

What?

adds a wrapper for multicvrp.

Why?

To make mulctivcrp mava compatible.

How?

This wrapper takes in the output from the multicvrp environment and converts it into a Mava suitable input.

sash-a
sash-a requested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! Big thing, make sure you use the MultiAgentWrapper Base class to avoid duplicating too much code

mava/utils/make_env.py Outdated Show resolved Hide resolved
mava/wrappers/jumanji.py Outdated Show resolved Hide resolved
mava/wrappers/jumanji.py Outdated Show resolved Hide resolved
mava/wrappers/jumanji.py Outdated Show resolved Hide resolved
mava/wrappers/jumanji.py Outdated Show resolved Hide resolved
mava/wrappers/jumanji.py Outdated Show resolved Hide resolved
mava/wrappers/jumanji.py Outdated Show resolved Hide resolved
mava/wrappers/jumanji.py Outdated Show resolved Hide resolved
mava/wrappers/jumanji.py Outdated Show resolved Hide resolved
sash-a
sash-a reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty great to me! Just gotta wait for the global state PR to go in so we can get rid of the hasattrs

mava/wrappers/jumanji.py Outdated Show resolved Hide resolved
sash-a
sash-a previously approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me also tested locally and seems to be running well!

RuanJohn
RuanJohn requested changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@RuanJohn RuanJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Louay-Ben-nessir! 🔥 Just a few question and suggestions from my side.

mava/wrappers/jumanji.py Outdated Show resolved Hide resolved
mava/wrappers/jumanji.py Show resolved Hide resolved
mava/wrappers/jumanji.py Outdated Show resolved Hide resolved
mava/wrappers/jumanji.py Show resolved Hide resolved
sash-a
sash-a previously approved these changes Mar 18, 2024
View reviewed changes
WiemKhlifi
WiemKhlifi suggested changes Mar 19, 2024
View reviewed changes
mava/wrappers/jumanji.py Outdated Show resolved Hide resolved
mava/wrappers/jumanji.py Outdated Show resolved Hide resolved
mava/wrappers/jumanji.py Outdated Show resolved Hide resolved
mava/wrappers/jumanji.py Outdated Show resolved Hide resolved
mava/wrappers/jumanji.py Outdated Show resolved Hide resolved
WiemKhlifi
WiemKhlifi suggested changes Mar 21, 2024
View reviewed changes
mava/wrappers/jumanji.py Outdated Show resolved Hide resolved
mava/wrappers/jumanji.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RuanJohn RuanJohn RuanJohn requested changes

@WiemKhlifi WiemKhlifi WiemKhlifi requested changes

@sash-a sash-a sash-a left review comments

@arnupretorius arnupretorius Awaiting requested review from arnupretorius arnupretorius is a code owner

@DriesSmit DriesSmit Awaiting requested review from DriesSmit DriesSmit is a code owner

@jcformanek jcformanek Awaiting requested review from jcformanek jcformanek is a code owner

@siddarthsingh1 siddarthsingh1 Awaiting requested review from siddarthsingh1 siddarthsingh1 is a code owner

@OmaymaMahjoub OmaymaMahjoub Awaiting requested review from OmaymaMahjoub OmaymaMahjoub is a code owner

@ulricharmel ulricharmel Awaiting requested review from ulricharmel ulricharmel is a code owner

@callumtilbury callumtilbury Awaiting requested review from callumtilbury callumtilbury is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@Louay-Ben-nessir Louay-Ben-nessir

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Louay-Ben-nessir @sash-a @RuanJohn @WiemKhlifi