Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove client4/client6 and anything using them #459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rminnich
Copy link
Contributor

Remove long-deprecated client4/client6 packages that no longer build
on bsd or darwin. This is a long-standing problem.

Remove all things depending on them, which have no users we know of.

Signed-off-by: Ronald G. Minnich rminnich@gmail.com

Remove long-deprecated client4/client6 packages that no longer build
on bsd or darwin. This is a long-standing problem.

Remove all things depending on them, which have no users we know of.

Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #459 (c253ca7) into master (3c283ff) will increase coverage by 5.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
+ Coverage   67.42%   72.80%   +5.37%     
==========================================
  Files          90       83       -7     
  Lines        3758     3217     -541     
==========================================
- Hits         2534     2342     -192     
+ Misses       1053      723     -330     
+ Partials      171      152      -19     
Flag Coverage Δ
integtests ∅ <ø> (∅)
unittests 72.80% <ø> (+5.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c283ff...c253ca7. Read the comment docs.

@insomniacslk
Copy link
Owner

insomniacslk commented Jan 21, 2022

CC @tfg13 - we only depend on it for OSF. In order to merge this PR we should:

  • migrate to nclient{6,4}
  • test through our OSF pipeline
  • release to our customers, and merge once confirmed that it's working

Also CC @BigValen as the owner of our internal code that uses this. I can help with the above steps if needed

@pmazzini
Copy link
Collaborator

Related pinterest/bender#39

@pmazzini
Copy link
Collaborator

For awareness, the netboot package being removed here is used in r-root.

https://github.com/u-root/u-root/blob/main/cmds/boot/fbnetboot/main.go#L28

@pmazzini pmazzini mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants