Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix batching in DIG #114

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

[WIP] Fix batching in DIG #114

wants to merge 25 commits into from

Conversation

gsarti
Copy link
Member

@gsarti gsarti commented Dec 2, 2021

Description

Fixes #113

Type of Change

🔧 Bug fix (non-breaking change which fixes an issue)

@gsarti
Minor fixes, problem persists
f0465b7
@gsarti
Polishing model loading with pre-loaded models support
3bf685e
@gsarti
Decoupled decoder-only models
edfb5db
@gsarti
Decoupled decoder-only attribute args formatting, minor typing adjust…
a384a21 
…ments
@gsarti
Merge remote-tracking branch 'origin/main' into decoder-only-support
b79cd28 
* origin/main:
  Python 3.11 CI support (#146)
  Added Python 3.11 checks
@gsarti
MPS GPU support
ba8d041
@gsarti
Fixed GPU backend check, optional deps separation
dc85873
@gsarti
Fix safety
bbe1f5f
@gsarti
Architecture classes, fix partial attribution
ac92bd6
@gsarti
Further refactoring of architecture-specific steps
8acb6cf
@gsarti
Further refactoring of architecture-specific steps
ff43fbd
@gsarti
Decoder attribution working (buggy)
07224fd
@gsarti
Fix encoder-decoder input
90a47ca
@gsarti
Adjustments for decoder-only attribution visualization
21dbe42
@gsarti
Decoder-only attribution working
27d1a77
@gsarti
Fixed batched constrained decoder-only attribution and single decoder…
9a79f13 
…-only attribution
@gsarti
Support for missing unk/eos tokens in HF model
1961198
@gsarti
Support for missing unk/eos tokens in HF model
92bcce3
@gsarti
Fixed attr pos for batch decoder-only, update readme
d9bca12
@gsarti
Arch methods reorg, fix seq attr conversion bug for n=1, extra tests
4141171
@gsarti
Update deps
8649606
@gsarti
Merge decoder-only-support into fix-batch-dig
b301363
@gsarti
Fix compat with decoder-only, batch result mismatch
fd53bc4
@gsarti
Copy link
Member Author

gsarti commented Nov 30, 2022

Current status:

  • DIG attribution was made compatible with newer changes (decoder-only model support, etc.) and supports both source and source-target attribution.
  • The problematic behavior of inconsistent outputs when testing the same input alone vs. inside a batch persist. The issue is probably in the scale_input function call inside DiscretizedIntegratedGradient.attribute, since the rest is mostly compatible with the original IG attribution.
  • Open question: is return_convergence_delta meaningful in this setting? First thoughts: it could provide information on the distance from a good non-orthogonal path, but should not be used as in IG.

@gsarti gsarti mentioned this pull request Dec 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent batching for DiscretizedIntegratedGradients attributions
1 participant
@gsarti