-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wikipedia #161
Open
JaimieMurdock
wants to merge
7
commits into
master
Choose a base branch
from
wikipedia
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Wikipedia #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
I’m currently trying to get some new programmers hired… if so, one of them could be put on this task — perhaps Kirtan’s friend Sriram if it all works out.
C.
… On Feb 20, 2018, at 20:11, Jaimie Murdock ***@***.***> wrote:
Some code that's not well-tested, but might be useful!
You can view, comment on, or merge this pull request online at:
#161 <#161>
Commit Summary
Initial version of `corpus_from_wikipedia`
Rewrote `corpus_from_wikipedia` for minimal memory consumption.
Memory improvements.
Bug fix
Added `trim_urls` and other tricks for efficiency.
Bug fix.
Merge branch 'master' into wikipedia
File Changes
A vsm/extensions/wikipedia.py <https://github.com/inpho/vsm/pull/161/files#diff-0> (420)
Patch Links:
https://github.com/inpho/vsm/pull/161.patch <https://github.com/inpho/vsm/pull/161.patch>
https://github.com/inpho/vsm/pull/161.diff <https://github.com/inpho/vsm/pull/161.diff>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#161>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AArCqwCJvugFzAp24JhJ8pe_6UnZ2jqkks5tW20-gaJpZM4SM7Vc>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code that's not well-tested, but might be useful!