fix scroll to column in rtl #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidholisz
force-pushed
the
fix-scrolling-to-column
branch
from
f0e8def
to
57554a9
Compare
dawidholisz
commented
Nov 8, 2021
Comment on lines
+82
to
+86
| const columnIndex = computedProps.rtl | ||
| ? columnsCount - col.computedVisibleIndex | ||
| : col.computedVisibleIndex; | ||
| computedProps.scrollToColumn(columnIndex, { duration: 50 }); | ||
| }); |
There was a problem hiding this comment.
i face the same issue @team could you check and merge this change plz?!
|
I noticed that after applying prettier, it is hard to notice my changes. I added comment with my changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue with scrolling to the column on editing started. For LTR it works correctly but when we pass
rtl={true}to a component, UI is switched but scroll doesn't work like expected. When I click on the last column (in rtl it is first from left), the grid scrolls to the first column from the right. I add a condition that checks if we use rtl mode.To reproduce it, I added few dump columns (horizontal scroll must be visible)
Demo:
Before:
https://user-images.githubusercontent.com/15018254/140797892-dbc5b9d3-76e1-435a-8d6a-623a7cfb0212.mp4
After:
https://user-images.githubusercontent.com/15018254/140795769-26462f5b-e6bd-4e90-975c-6548c34417f7.mp4