A few misc changes! #731
Open
A few misc changes! #731
+115
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InkList: Adds == operator for InkLists, and some other changes Jon(?) wrote for Overboard but never merged in ListDefinitionsOrigin: Null input check. Can't recall why we added this! Story: These were changes used in the InkPlayerEditorWindow Path+StoryState: This is a new feature! It enables you to get a more practical path string for the story state, which I've found super helpful as a way of checking where the player REALLY is in the story (which can then be used to rewind them, track state, find bugs, etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got a few changes to the version of ink I'm using that I'd love to get into the main branch! Apologies they're all in a single request.
InkList: Adds == operator for InkLists, and some other changes Jon(?) wrote for Overboard but never merged in
ListDefinitionsOrigin: Null input check. _allUnambiguousListValueCache items should never be null, so we don't even want to check.
Story: These were changes used in the InkPlayerEditorWindow
Path+StoryState: This is a new feature! It enables you to get a more practical path string for the story state, which I've found super helpful as a way of checking where the player REALLY is in the story (which can then be used to rewind them, track state, find bugs, etc)