4835 - Follow up qa fix to tabbable #4836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcconechy
changed the title
EdwardCoyle
previously approved these changes
Feb 11, 2021
EdwardCoyle
approved these changes
Feb 12, 2021
deep7102
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the details for making this change. What existing problem does the pull request solve?
Fixes a follow up issue with the search field tabbable setting added recently. The issue is it wont work for collapsible search so QA found a place i needed to disable it on.
Also added a approved and approved-filled icon from design by bumping the ids-design version
Related github/jira issue (required):
Fixes #4835
Fixes #4775
Steps necessary to review your pull request (required):