-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3666 - Update the design of widget counts in uplift #4054
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good but the design has a few more variations. I would suggest in priority:
- The example on https://www.figma.com/file/UTwbDbeB1Xv34Uz6js36L4/ids-widget-counts?node-id=0%3A1 "Icon on Count"
- "Informational button for truncation "
- "BI Colors" ? Can it be other colors in the 07 color range?
- Its ok if soho theme is also the line only and not solid color
- what if there is 2 or 6 rings?
Can skip:
- "text based" examples
Calling this WIP as it needs a few more things. |
@tmcconechy you can take a look now. The CI will probably failed because of baseline image. But will fix it after. |
Looking great. Maybe just two things now
|
Looks like you got it all covered now 😄 Maybe just fix the test and we call it done. |
@tmcconechy this should be good to go now. ☕ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍌
Explain the details for making this change. What existing problem does the pull request solve?
Implementing the new design for widget count in uplift. I've also tweaked some positions in non uplift.
This is not limiting to the four colors that was in the design, we can use all the color palettes that we have, even adding other colors in the future.
Related github/jira issue (required):
Closes #3666
Steps necessary to review your pull request (required):
Included in this Pull Request: