Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2722 - Q/A issues for Fontpicker component [v4.24.x] #3286

Merged
merged 3 commits into from
Dec 20, 2019

Conversation

EdwardCoyle
Copy link
Contributor

Explain the details for making this change. What existing problem does the pull request solve?
This PR addresses these two issues:

  • Changes to settings handling on Toolbar Flex to accommodate passing down Popupmenu settings to an action button caused some AJAX calls not to be properly handled. The logic for passing settings has been changed to correctly target action buttons.
  • Fixed the alignment of the dropdown icon on both Edge (Vibrant) and Firefox (Subtle)

Related github/jira issue (required):
Closes #2722

Steps necessary to review your pull request (required):
Pull this branch, build, run the app. Then...

To test the Ajax Calls are working properly:

To test the icon alignment:

@EdwardCoyle EdwardCoyle requested a review from a team as a code owner December 20, 2019 16:24
@EdwardCoyle
Copy link
Contributor Author

@Sovia pinging you just to let you know about the short-lived issue with Flex Toolbar / AJAX. The problem was in our 4.24.x branch for about a day or so. This PR should fix it.

@tmcconechy tmcconechy merged commit de6c7e0 into 4.24.x Dec 20, 2019
@tmcconechy tmcconechy deleted the 2722-fix-arrow-edge branch December 20, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants