-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2722 - Add Fontpicker Component to Editor #3219
Conversation
@Fruko if you're able, would you mind testing this in your environment to see if it meets your requirements? |
@EdwardCoyle sure, the branch or after it's merged to master? |
@Fruko Either way. But if you do try the branch and find some suggestions we can get them in sooner before merged. But either will help. |
The design put some extra space between the text and the arrow. I'm not sure why the in-page one doesn't have the arrow... I can look into it |
Sorry for the delay, the changes are good for our use case. Thanks! |
Explain the details for making this change. What existing problem does the pull request solve?
This PR adds a new Fontpicker component to IDS. The Fontpicker has been integrated into the Editor component, and takes the place of the
h3
andh4
buttons that previously existed.Related github/jira issue (required):
Closes #2722
Steps necessary to review your pull request (required):
There are also a handful of new functional tests for this component that should all pass.
Included in this Pull Request: