Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2025 - Images tabbable .image-auto #2450

Merged
merged 5 commits into from
Jun 28, 2019
Merged

Conversation

davidcarlsonberg
Copy link
Contributor

@davidcarlsonberg davidcarlsonberg commented Jun 27, 2019

Explain the details for making this change. What existing problem does the pull request solve?
This provides a solution for the desire to have a focus-state on an image where the width and height are not defined by the CSS. Creates a class .image-auto for this purpose and places it in the example page for demonstration purposes.
History here: #2025 (comment)

Related github/jira issue (required):
Close #2025 .

Steps necessary to review your pull request (required):

Included in this Pull Request:
- [ ] An e2e or functional test for the bug or feature.

  • A note to the change log.

Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pwpatton wanted it so that the class was on the image instead ..

<div class="image-auto">
              <img src="http://placehold.it/300x350/999999/FFFFFF" alt="image-auto 300x350" tabindex="0">
            </div>

vs


<img class="image-auto" src="http://placehold.it/300x350/999999/FFFFFF" alt="image-auto 300x350" tabindex="0">

My suggestion around that is to change the css so both work and change the example page to show it on the image. Im not sure why we did it like that originally.

Also i guess we can remove image-auto placeholder as thats not going to work without a height since its just the icon and missing the white

@tmcconechy tmcconechy merged commit 26089e1 into master Jun 28, 2019
@tmcconechy tmcconechy deleted the 2025-tabbable-images-image-auto branch June 28, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility - Need a Tabbable Profile Image
3 participants