2025 - Images: Make tabbable

[davidcarlsonberg]

Explain the details for making this change. What existing problem does the pull request solve?
Images were not tabbable. Focus state was off in Firefox and IE.

Related github/jira issue (required):
Closes #2025.

Steps necessary to review your pull request (required):

• Pull branch, run app
• Visit the below pages in Chrome, Safari, Firefox, and IE. Tab through and ensure proper focus state materializes.
  • http://localhost:4000/components/images

[tmcconechy]

Is it just me? But im not seeing the focus styled as expected on chrome mac. Im seeing the default one as if the rules are not applying.

On all pages http://localhost:4000/components/images I did restart a bunch of times

[tmcconechy]

I'm not seeing the correct visual focus state

[davidcarlsonberg]

@tmcconechy What should be the correct visual focus state?

[tmcconechy]

Should be the same as http://localhost:4000/components/input/example-index.html

But you were using the mixin. So not sure why. Seems like its not applying the rule

  border: solid 1px #368ac0;
  box-shadow: 0 0 4px 3px rgba(54, 138, 192, 0.3);
  outline: none;
  outline-color: transparent;

[tmcconechy]

Hmm ok @EdwardCoyle but now i see on this comment #2025 (comment) he said it was fine. I dont see the point of only fixing this in ff and IE.

So i think lets maybe make it work everywhere but they can opt-in by adding the tabindex if they want it to be focusable. So both situations would be possible

[tmcconechy]

🍌 🍾