2026 - Modal: Tabbing initial focus

[davidcarlsonberg]

Explain the details for making this change. What existing problem does the pull request solve?
This new test page serves to demonstrate that the first focused item in a modal with a toolbar and a datagrid is the first non-disabled toolbar button.

Related github/jira issue (required):
Resolves #2026.

Steps necessary to review your pull request (required):

• Pull branch, run app
• Visit http://localhost:4000/components/modal/test-toolbar.html
  • Click "Open Modal"
  • Observe the first focused and tabbable item is the first non-disabled button in the toolbar.

¿- [ ] An e2e or functional test for the bug or feature.?
¿- [ ] A note to the change log.?

[tmcconechy]

Actually rereading this issue this looks fine but what if you disabled the first button like in the issue? Then does it still work ok? Lets try that

[tmcconechy]

Ok Cool yeah looks like our logic is fine. Must be an issue on their end and now we can prove that.

[EdwardCoyle]

I'm going to approve since the test demos the case, but I think there's another focus trap surrounding Datagrid inside of Modals we should address:

• Open http://localhost:4000/components/modal/test-toolbar.html
• Click "Open Modal"
• Press Tab key once to move focus to the grid
• Press Shift + Tab to try and move focus back to the button. See that it doesn't move focus out of the grid.
• The same occurs when tabbing all the way through all grid cells. It's not possible to then press Tab to get out of the grid and into the Pager bar, or beyond.

Not sure if it's related to this or not... what do you think @tmcconechy ?

[tmcconechy]

Yes that is an issue @EdwardCoyle but i see it not only on this branch. It would be good to make a new issue for later. Note that the mentioned issue doesnt occur on http://localhost:4000/components/datagrid/example-index.html

[EdwardCoyle]

Yeah, seems to be specific to the tabbing in Modals