1281 - Adjust Tree Grid indentation to be make the tree more readable. #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisfried
requested review from
davidcarlsonberg,
deep7102,
EdwardCoyle and
tmcconechy
as code owners
|
FYI, We have a fix for the test issue that will shortly be merged to master. I'll let you know when its ready to merge on this branch. Nice Fix - didnt know it would be so simple ;) |
|
@chrisfried please try to merge master back now on your branch and push, should resolve the test. |
EdwardCoyle
approved these changes
Nov 30, 2018
davidcarlsonberg
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current design of the tree grid is misleading in the way it reads. This PR aligns the text of all items at the same depth to improve legibility.
Related github/jira issue (required): #1281
Steps necessary to review your pull request (required):
Take a look at any of the data grid tree examples.