Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Indicator Request #4775

Closed
InforChloeChen opened this issue Jan 25, 2021 · 18 comments · Fixed by #4836
Closed

Icon Indicator Request #4775

InforChloeChen opened this issue Jan 25, 2021 · 18 comments · Fixed by #4836
Assignees
Labels
design Needs input from IDS Design Team type: enhancement ✨ [2] Velocity rating (Fibonacci)

Comments

@InforChloeChen
Copy link

Is your feature request related to a problem or use case? Please describe.

Infor WFM team is working on a new feature of shift request preference, employees can send personal preference through the user end, and a scheduler will check all requests and assign shifts accordingly on the web app. We require 6 similar but slightly different icon indicators to represent the shift status: 1. Work Request 2. Not Work Request 3. Honoured Work Request 4. Denied Work Request 5. Honoured Not Work Request 6. Denied Not Work Request. The icon size needs to fit into a space of 15(H) * 37 (W) px as the smallest one. The regular size will be 32/24/16 as standardized on the shift cards.

Describe the solution you'd like
6 similar but slightly different icon indicators for these 6 statuses.

Describe alternatives you've considered
Icons with different background colours, constraints: there are existing colours on the shift panel, easy to confuse and hard to read.

Additional context
I am Chloe Chen and helping with the design part. Please let me know how I can collaborate or if you need the Figma file.
If you have any question, please feel free to contact me anytime: chloe.chen@infor.com
IconIndicators

@tmcconechy tmcconechy added design Needs input from IDS Design Team type: enhancement ✨ labels Jan 25, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.38.x (Feb 2021) Sprint via automation Jan 25, 2021
@tmcconechy tmcconechy added the [2] Velocity rating (Fibonacci) label Jan 25, 2021
@tmcconechy
Copy link
Member

Will discuss this in sprint planning. We currently need the icons to be in sketch but someone is working on it now. So you can add them later possibly. Will give some details soon

@InforChloeChen
Copy link
Author

Thank you. Please consider the readability and visibility for the smallest icon size ( within a 15 * 37-px-cell).

@InforChloeChen
Copy link
Author

Please see the Figma file, copy and paste into your browser https://www.figma.com/file/9EVrLj3TM13Mxclqgq1MYC/Schedule-Request?node-id=0%3A1
Please see the 'Icon Indicator' session.
Thank you

@kevinwhitedesign
Copy link

Hey @InforChloeChen ! If we add these icons they'll be available to all our other Infor teams so I just want to do my part to determine if they will be valuable (so no hard feelings). Can you talk about the need for the icons in the UI? It's important to consider that if these icons are not shown with text they may be confusing or not clearly communicate their meanings. Would you mind answering a few questions?

@tmcconechy
Copy link
Member

My other concern would be the use of color as a status. This is not accessible. In addition we decided on 3 basic sizes.

large: 24,
normal: 18,
small: 10

The really smallers ones are almost too small to see for me

@InforChloeChen
Copy link
Author

Hi, @kevinwhitedesign, always good to have those icons available for re-use in other areas if it fits. These icons represent the status of the personal request from the Employee. Only the scheduler and admin can see all these icons indicator ( 6 different statuses). When the scheduler can see the requests and hovers the shift cells, a bigger-sized icon and shift information show up on a pop-up as an assistant information provider. Please see the Indicator design session to learn more about the user flow.
Figma filehttps://www.figma.com/file/9EVrLj3TM13Mxclqgq1MYC/Schedule-Request?node-id=0%3A1

  • the human shape is related to the employee, and we can remove it to pass the accessibility.
  • for the existing IDS icon Library, I didn't find six similar shaped- icons. Do you have any recommendations?
  • All the icons are TBD; please free to make adjustments to match the rule.

Btw, the smallest size of the icons could be 12 or 14px (preferred).
Thank you

@kevinwhitedesign
Copy link

Hey @InforChloeChen yeah - do the devs you work with access icons via IDS? Or do they have their own standalone library? If these are icons that your team will use internally then you can apply your sizes but we recommend [and can only use] the 10, 18 & 24 icon sizes aformentioned by Tim.

Yeah looks like these are a bit specific but we do have more status-like icons you can preview here https://master-enterprise.demo.design.infor.com/components/alerts/example-index.html?theme=uplift&variant=light&colors=0066D4

Those other answers sound good! Let's just meet about it briefly with @laurensteiger + @elizabethhartley and we can go from there.

@InforChloeChen
Copy link
Author

InforChloeChen commented Feb 8, 2021

Thank you for your meeting last week. After we discussed the statuses, we will move forward with the existing icon as attached. But we may need help with the first icon to add into the Library, which is not in the library. The second icon - Not work request ( a cross in the middle of a note) existed, but we didn't find a checkmark one. Please see the updated icons through this Figma file: https://www.figma.com/file/9EVrLj3TM13Mxclqgq1MYC/Schedule-Request?node-id=0%3A1

icon update

Please let me know if you cannot open it.
Thanks

@kevinwhitedesign
Copy link

Ok thanks for going back on this and figuring out how we can best utilize existing IDS icons for WFM! We can see how this icon might prove valuable outside of WFM as well. Here's where we're at and we'll be uploading to IDS soon.
Screen Shot 2021-02-10 at 11 01 23 AM

@tmcconechy
Copy link
Member

Thanks @kevinwhitedesign once you add a PR for it let me know (or ill see it) and check it...

@kevinwhitedesign
Copy link

Awesome at @tmcconechy look out for a PR from @laurensteiger. What release do you think this icon would be available in?

@tmcconechy
Copy link
Member

Would be in 4.38 if it comes sometime in the coming 2 weeks...

@laurensteiger
Copy link

Pull request
infor-design/design-system#459

@tmcconechy tmcconechy self-assigned this Feb 10, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.38.x (Feb 2021) Sprint via automation Feb 10, 2021
@tmcconechy tmcconechy moved this from To do to In progress in Enterprise 4.38.x (Feb 2021) Sprint Feb 10, 2021
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.38.x (Feb 2021) Sprint Feb 11, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.38.x (Feb 2021) Sprint Feb 12, 2021
@jbrcna
Copy link
Contributor

jbrcna commented Feb 15, 2021

the issue is now resolved.

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.38.x (Feb 2021) Sprint Feb 15, 2021
@InforChloeChen
Copy link
Author

My other concern would be the use of color as a status. This is not accessible. In addition we decided on 3 basic sizes.

large: 24,
normal: 18,
small: 10

The really smallers ones are almost too small to see for me

Sorry, One more question, Time mentioned the icon size will be 24, 18, 10 px, because of space limitation, I think we are still following this size guide, right?

@kevinwhitedesign
Copy link

@InforChloeChen I just checked the latest design system icon file and both approve icons are in there, set at 18px size. @tmcconechy apparently the developers on Chloe's team can't access the icons do you see them on your side?

@tmcconechy
Copy link
Member

tmcconechy commented Apr 30, 2021

Yes im seeing them on https://master-enterprise.demo.design.infor.com/components/icons/example-index.html
Screen Shot 2021-04-30 at 10 52 21 AM

Where are you looking when you try to access them? Maybe check which version of IDS your using? And make sure its the latest

@kevinwhitedesign
Copy link

@InforChloeChen Tim has them on his end in IDS environment, maybe check with your devs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Needs input from IDS Design Team type: enhancement ✨ [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants