Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget Count: Needs uplift fixes #3666

Closed
tmcconechy opened this issue Mar 26, 2020 · 25 comments · Fixed by #4054
Closed

Widget Count: Needs uplift fixes #3666

tmcconechy opened this issue Mar 26, 2020 · 25 comments · Fixed by #4054
Assignees
Labels
design Needs input from IDS Design Team focus: uplift theme Items related to completion the Uplift theme type: bug 🐛 [5] Velocity rating (Fibonacci)

Comments

@tmcconechy
Copy link
Member

tmcconechy commented Mar 26, 2020

Describe the bug
Update the widget counts to encorporate new designs https://www.figma.com/file/UTwbDbeB1Xv34Uz6js36L4/ids-widget-counts?node-id=0%3A1

Modify this for uplift and soho theme.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://master-enterprise.demo.design.infor.com/components/counts/example-widget-count.html
  2. Compare to https://master-enterprise.demo.design.infor.com/components/counts/example-widget-count.html?theme=uplift&variant=light
  3. Compare to https://www.figma.com/file/UTwbDbeB1Xv34Uz6js36L4/ids-widget-counts?node-id=0%3A1
  4. Add new aspects of the design

Expected behavior
Looks like new designs

Version

  • ids-enterprise: [e.g. v4.27]

Screenshots
78367228-5b693600-75df-11ea-9e91-9502088d8e06

Platform

  • Any
@tmcconechy tmcconechy changed the title Widget Count: Needs uplift fixes. Widget Count: Needs uplift fixes Mar 26, 2020
@tmcconechy
Copy link
Member Author

cc @kevinwhitedesign what do you think?

@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) design Needs input from IDS Design Team type: bug 🐛 labels Mar 26, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.29.x (May 2020) Sprint via automation Mar 26, 2020
@kevinwhitedesign
Copy link

Yeah these changes generally make sense to me. Any more background on this? Specifics?

This is what I'm seeing btw:
https://www.dropbox.com/s/yjggvyenuvu01ws/Screenshot%202020-03-31%2018.24.37.png?dl=0

@tmcconechy
Copy link
Member Author

tmcconechy commented Apr 1, 2020

Ok sounds good. Im not sure about the background. I mean in general this is just a "dashboard" of counts of certain types. The new design was something manilla provided to a team and we noticed a mismatch.

The only problem with it is that the text especially the yellow is not visible. Maybe we can come up with something with:

  • the color and counts
  • an alert icon
  • text that is readable with no contrast issues

@kevinwhitedesign
Copy link

Oh gotcha, thanks for that background. I remember doing a few of these in the subtle-era.

Maybe this would work. What did you mean by alert icon?
https://www.figma.com/file/UTwbDbeB1Xv34Uz6js36L4/ids-widget-counts?node-id=0%3A1

@tmcconechy
Copy link
Member Author

Yeah thats a nice treatment. Idea being just show the icon "somewhere" in case the use is color blind and cant determine the states by color alone. That could definitely work.

@dhumalkishor
Copy link

Need to provision to add label "Violation count by Role" or "Violation count by User" in widget.

@tmcconechy
Copy link
Member Author

@dhumalkishor can u explain this further? I'm not sure where you wont those labels? We have a space under each count for a label. Wont that work?

@dhumalkishor
Copy link

At the bottom of the widget so user can understand this count is for which violating object.

@tmcconechy
Copy link
Member Author

You mean like the title in the widget? That seems like a good place. Might need a sketch for what your suggestion to get it right

@dhumalkishor
Copy link

Widget

@tmcconechy
Copy link
Member Author

Gotcha - do you need to change it? Like maybe a dropdown? Like on top here https://master-enterprise.demo.design.infor.com/components/cards/example-action-menu-button.html

@kevinwhitedesign
Copy link

It's a filtered view of multiple user violations? And filtered by user?

@dhumalkishor
Copy link

Filters
These are the filters we are using for this widget.

@tmcconechy
Copy link
Member Author

OK, So its just an extra sub label. The label being the widget title. Clarifying above.

@tmcconechy tmcconechy added the focus: uplift theme Items related to completion the Uplift theme label Apr 30, 2020
@tmcconechy
Copy link
Member Author

Cc @inforandy - for "widget stuff"

@ericangeles ericangeles self-assigned this May 19, 2020
@kevinwhitedesign
Copy link

@dhumalkishor 👋 would you mind giving us a view into the background information of this usecase?

@dhumalkishor
Copy link

Hi Kevin,
We are using this widget to show violations count. There are two violating objects in our system, One is Role and second one is User. Looking at this widget user is not able to find this count is for which object. Currently to see object user need to go configurations every-time.

@tmcconechy tmcconechy added this to To do in Enterprise 4.30.x (June 2020) Sprint via automation May 20, 2020
@tmcconechy tmcconechy added [5] Velocity rating (Fibonacci) and removed [2] Velocity rating (Fibonacci) labels May 20, 2020
@kevinwhitedesign
Copy link

Oh awesome thanks for that @dhumalkishor what's the difference between user & role violation objects? What's the goal of a user looking at this widget? Will they look at 'high' and say to themselves, wow that's a lot I have to look into this?

@dhumalkishor
Copy link

Infor GRC is internal auditing tool for auditors. Auditor create rules by using our product and do analysis of that rules. Analysis generate violations based on rules. those violations could be for user or for role. All this violations are threat to business.

@ericangeles
Copy link
Contributor

Hello @tmcconechy @kevinwhitedesign, do we have the final design for this ticket? So we can move now to the development stage. Thanks!

@tmcconechy
Copy link
Member Author

The design was here https://www.figma.com/file/UTwbDbeB1Xv34Uz6js36L4/ids-widget-counts?node-id=0%3A1 but @kevinwhitedesign can let us know if it need anything more?

@ericangeles
Copy link
Contributor

ericangeles commented Jun 15, 2020

So there will be no text below of the widget counts?

@ericangeles ericangeles moved this from To do to In progress in Enterprise 4.30.x (June 2020) Sprint Jun 17, 2020
@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.30.x (June 2020) Sprint Jun 18, 2020
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.30.x (June 2020) Sprint Jun 24, 2020
@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Ready for QA (rc) in Enterprise 4.30.x (June 2020) Sprint Jun 24, 2020
@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (rc) to Done in Enterprise 4.30.x (June 2020) Sprint Jun 24, 2020
@kevinwhitedesign
Copy link

@ericangeles I suggested in the designs that this message could be indicated via the title or on hover. Sry for the delay!

@tmcconechy
Copy link
Member Author

@kevinwhitedesign have a look https://master-enterprise.demo.design.infor.com/components/counts/example-widget-count.html we implemented. I think we did what you had specified 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Needs input from IDS Design Team focus: uplift theme Items related to completion the Uplift theme type: bug 🐛 [5] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants