WIP: fix(tsm1): shrinking the time window for merging overlapping blocks #23405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when scanning data with overlapping blocks, the current algorithm would maximize time window(though we do have comments mentioning it *should* shrink the window). If we have a block with a long time window which overlaps with many other blocks, the merging operation would be time consuming especially with string data type. This change simply makes the code in line with original comments by shrinking the window to merge.
foobar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when scanning data with overlapping blocks, the current algorithm would
maximize time window(though we do have comments mentioning it should
shrink the window). If we have a block with a long time window
which overlaps with many other blocks, the merging operation would be
time consuming especially with string data type.
This change simply makes the code in line with original comments by
shrinking the window to merge.
Closes #23354