Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add --version option to influx query #379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsternberg
Copy link

The --version option will execute a query against influxdb that returns
the current flux version on the server.

It uses the query from the docs:
https://docs.influxdata.com/influxdb/v2.2/query-data/flux/flux-version/

The --version option will execute a query against influxdb that returns
the current flux version on the server.

It uses the query from the docs:
https://docs.influxdata.com/influxdb/v2.2/query-data/flux/flux-version/
@samhld
Copy link

samhld commented May 23, 2022

Thanks, @jsternberg ! Whoever reviews, can you verify that this flag only applies for the query subcommand? I'm fine with having this be universal to influx but would then likely need its name changed to something like --flux-version.

@serenibyss serenibyss self-requested a review May 23, 2022 19:59
@serenibyss
Copy link
Contributor

... can you verify that this flag only applies for the query subcommand? I'm fine with having this be universal to influx but would then likely need its name changed to something like --flux-version.

It is currently only on the influx query subcommand, though I do wonder if a new subcommand for this, like influx flux-version would be even better. I'll leave it up to you @jsternberg

Copy link
Contributor

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming we are sticking with influx query --version and not some other method of checking the version as mentioned above

@samhld
Copy link

samhld commented May 23, 2022

@DStrand1 I had the same thought. In my experience, a flag usually means I'm modifying/configuring a command in some way. It may make more sense to make this its own subcommand, similar to how version is for the version of the DB and the CLI. That said, I'd rather leave that to be democratically decided by developers with more of a frame reference for standards.

@jsternberg thoughts on making this its own subcommand?

@samhld
Copy link

samhld commented May 24, 2022

@jsternberg A quick poll was taken on the above options and making this its own subcommand won. Would it be trouble to make this its own subcommand instead of a flag to the query subcommand?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants