feat: add max age to replications create and update (#367)

influxdata · Mar 18, 2022 · 88ba346 · 88ba346
1 parent c8c7c1c
commit 88ba346
Show file tree

Hide file tree

Showing 6 changed files with 90 additions and 3 deletions.
diff --git a/api/api_write.gen.go b/api/api_write.gen.go
diff --git a/api/contract/openapi b/api/contract/openapi
diff --git a/api/model_replication_creation_request.gen.go b/api/model_replication_creation_request.gen.go
diff --git a/api/model_replication_update_request.gen.go b/api/model_replication_update_request.gen.go
diff --git a/clients/replication/replication.go b/clients/replication/replication.go
@@ -25,6 +25,7 @@ type CreateParams struct {
 	MaxQueueSize           int64
 	DropNonRetryableData   bool
 	NoDropNonRetryableData bool
+	MaxAge                 int64
 }
 
 func (c Client) Create(ctx context.Context, params *CreateParams) error {
@@ -41,6 +42,7 @@ func (c Client) Create(ctx context.Context, params *CreateParams) error {
 		LocalBucketID:     params.LocalBucketID,
 		RemoteBucketID:    params.RemoteBucketID,
 		MaxQueueSizeBytes: params.MaxQueueSize,
+		MaxAgeSeconds:     params.MaxAge,
 	}
 
 	// set optional params if specified
@@ -118,6 +120,7 @@ type UpdateParams struct {
 	MaxQueueSize           int64
 	DropNonRetryableData   bool
 	NoDropNonRetryableData bool
+	MaxAge                 int64
 }
 
 func (c Client) Update(ctx context.Context, params *UpdateParams) error {
@@ -153,6 +156,10 @@ func (c Client) Update(ctx context.Context, params *UpdateParams) error {
 		body.SetDropNonRetryableData(*dropNonRetryableDataBoolPtr)
 	}
 
+	if params.MaxAge != 0 {
+		body.SetMaxAgeSeconds(params.MaxAge)
+	}
+
 	// send patch request
 	res, err := c.PatchReplicationByID(ctx, params.ReplicationID).ReplicationUpdateRequest(body).Execute()
 	if err != nil {

diff --git a/cmd/influx/replication.go b/cmd/influx/replication.go
@@ -72,7 +72,7 @@ func newReplicationCreateCmd() cli.Command {
 			&cli.Int64Flag{
 				Name:        "max-queue-bytes",
 				Usage:       "Max queue size in bytes",
-				Value:       67108860, // source: https://github.com/influxdata/openapi/blob/588064fe68e7dfeebd019695aa805832632cbfb6/src/oss/schemas/ReplicationCreationRequest.yml#L19
+				Value:       67108860, // source: https://github.com/influxdata/openapi/blob/master/src/oss/schemas/ReplicationCreationRequest.yml
 				Destination: &params.MaxQueueSize,
 			},
 			&cli.BoolFlag{
@@ -85,6 +85,12 @@ func newReplicationCreateCmd() cli.Command {
 				Usage:       "Do not drop data when a non-retryable error is encountered",
 				Destination: &params.NoDropNonRetryableData,
 			},
+			&cli.Int64Flag{
+				Name:        "max-age",
+				Usage:       "Specify a maximum age (in seconds) for replications data before it is dropped, or 0 for infinite",
+				Value:       604800, // source: https://github.com/influxdata/openapi/blob/master/src/oss/schemas/ReplicationCreationRequest.yml
+				Destination: &params.MaxAge,
+			},
 		),
 		Action: func(ctx *cli.Context) error {
 			api := getAPI(ctx)
@@ -228,6 +234,11 @@ func newReplicationUpdateCmd() cli.Command {
 				Usage:       "Do not drop data when a non-retryable error is encountered",
 				Destination: &params.NoDropNonRetryableData,
 			},
+			&cli.Int64Flag{
+				Name:        "max-age",
+				Usage:       "Specify a maximum age (in seconds) for replications data before it is dropped, or 0 for infinite",
+				Destination: &params.MaxAge,
+			},
 		),
 		Action: func(ctx *cli.Context) error {
 			api := getAPI(ctx)