chore: fix tough-cookie dependency #6050
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deals with the tough-cookie Prototype Pollution vulnerability issue.
tough-cookie@~2.5.0 comes from cypress@^8.4.1 package which contains cypress/request@^2.88.6 dependency containing tough-cookie in the vulnerable version. Currently, it can't be upgraded because even the latest version of cypress does not contain correct/fixed version of tough-cookie. Due to the fact it is a dev-dependency we can tolerate it.
tough-cookie@~2.5.0 comes from node-sass@7.0.0 contains request@^2.88.0. Fixed by updating version of node-sass to ^8.0.0 which dropped usage of the tough-cookie dependency at all.tough-cookie@^4.0.0 comes from jsdom@^19.0.0 - this pulls 4.1.3 as the latest version and it is considered safe.