Fix attachEvent type error #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi can you fix the conflicts please. |
…methods, so we need to mark them as optional.
jhsware
force-pushed
the
fix-attachevent-type-error
branch
from
2bc47e8
to
c385595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a type error in attachEventToDocument method.
A note though, perhaps we should remove:
The implementation was moved to core from inferno-compat and are specifically geared towards React-compatibility. Given how much React has evolved, perhaps it isn't worth keeping React-fixes in the core Inferno code base.
ref 1
ref 2