Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inferno router #1608 #1615

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Conversation

jhsware
Copy link
Contributor

@jhsware jhsware commented Nov 7, 2022

Closes #1608

@coveralls
Copy link
Collaborator

coveralls commented Nov 7, 2022

Coverage Status

Coverage increased (+0.01%) to 93.284% when pulling ebbb65a on jhsware:fix-inferno-router-#1608 into 4140367 on infernojs:master.

@jhsware
Copy link
Contributor Author

jhsware commented Nov 7, 2022

jest isn't injected in browser test causing

Firefox 105.0 (Mac OS 10.15) A <Link> underneath a <HashRouter> accepts an object `to` prop with state FAILED
        ReferenceError: jest is not defined in test.no-compat.index.1762362208.js (line 68712)
        __webpack_modules__</</<@test.no-compat.index.1762362208.js:68712:5
        <Jasmine>

I think this should be fixed in the test set up, but have no idea of how to configure it.

@Havunen
Copy link
Member

Havunen commented Nov 8, 2022

LGTM, thank you

@Havunen Havunen merged commit e3c3deb into infernojs:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Passing state with a Router link no longer works with inferno-router 8.0.3
3 participants