You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello,
Really sorry, this is my first Pull request and I figured out my commits are badly done (I should commit one change after another and not this way).
Already sent you an Email about that...
Here the changes made on the several files:
index.js : fixed the translated colors not being taken in account.
Language.html : fxed missing tags (<html></html>, <head></head>, <body></body>, </dt>, </dd>), Provided more anchors to summary. Externalize CSS (ref.css and ref.min.css) and improving styling (turtle.png, more space between blocks,...)
language-fr.html : guide FR translation.
l10n/lang-fr.json : Added Primitives translation. added some missing messages translation (there are still string that haven't beeing localized), added all logo colors translation.
cm/logo.js : adding french keywords to have CodeMirror syntax highlighting working.
turtle.js: filling out the turtle in green... I would suggest to make the turtle smaller...
This translation should be reviewed by french users. I translated arbitrary using this rules:
No accentuated words. For example, répète (translation of repeat)becomes repete.
Try to have small words (not so easy in french) but also understandible.
Yeah, I'm going to need you to submit separate PRs for the changes. You do this by having a separate branch for each "topic" or intended change, and submit a PR for each.
High level comments though:
Please don't add the "min" files or the workspace files
The CodeMirror change should be generalized in some way to not hard-code the terms; it should be reworked to use the localization files.
Splitting the CSS out of the language file should be done as a stand-alone change with no additions, so it's easier to understand what the changes are (e.g. adding the background image?)
Reformatting the language.html file, e.g. adding additional HTML tags, should be avoided, especially if unrelated to the change. Close tags are not needed for DT and DD, and replacing multiple DTs with BR changes the semantics of the doc.
Please don't add comments into the JSON files
It's not obvious how language-fr.html file would be used - there's probably a subtle change somewhere I'm not spotting.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Really sorry, this is my first Pull request and I figured out my commits are badly done (I should commit one change after another and not this way).
Already sent you an Email about that...
Here the changes made on the several files:
<html></html>,<head></head>,<body></body>,</dt>,</dd>), Provided more anchors to summary. Externalize CSS (ref.css and ref.min.css) and improving styling (turtle.png, more space between blocks,...)This translation should be reviewed by french users. I translated arbitrary using this rules:
répète(translation ofrepeat)becomesrepete.Thanks in advance for your patience.
Joël