Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Py_REFCNT(obj) instead of obj->ob_refcnt (allows building in nogil) #201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jimkring
Copy link

@jimkring jimkring commented Sep 6, 2023

here’s a suggestion from @colesbury:

This looks like it needs to use Py_REFCNT(obj) instead of obj->ob_refcnt. The reference count field changed (it's now two fields in "nogil Python), so you can't access them directly. The Python docs now say to use Py_REFCNT instead of ->ob_refcnt so maybe we can get this change upstreamed.

use Py_REFCNT(obj) instead of obj->ob_refcnt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant