Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for a circular dependency when using crypto-browserify with web module bundlers (in this case Angular CLI / webpack):
WARNING in Circular dependency detected: src/js/externals/crypto.ts -> node_modules/crypto-browserify/index.js -> node_modules/diffie-hellman/browser.js -> node_modules/diffie-hellman/lib/generatePrime.js -> node_modules/miller-rabin/lib/mr.js -> node_modules/brorand/index.js -> src/js/externals/crypto.ts
(Using
eval
this way feels a bit hackish, but I'm not aware of anything like Content Security Policy that would break it in a Node.js context, and I've been using this exact technique in all of @cyph's crypto libraries for a while now with no known issues.)