Disable source build cache on pocl/nvidia #749
Conversation
matthiasdiener
force-pushed
the
disable-build-cache-v2
branch
from
b9b8091
to
0656451
Compare
matthiasdiener
changed the title
matthiasdiener
force-pushed
the
disable-build-cache-v2
branch
3 times, most recently
from
a226c17
to
1a9ad0d
Compare
matthiasdiener
force-pushed
the
disable-build-cache-v2
branch
from
1a9ad0d
to
4ecc57c
Compare
| # This must be done before PoCL is actually loaded | ||
| from pyopencl.characterize import setup_pocl_cache_dirs | ||
| setup_pocl_cache_dirs() |
There was a problem hiding this comment.
Could you explain why this is here? This seems to defeat inter-run caching, which, in my book, is definitely desirable.
There was a problem hiding this comment.
This is a workaround for the intermittent failures we have seen as part of #738.
I couldn't think of a way to ensure PID-local caches that also support inter-run caching, without resorting to using MPI rank numbers (which wouldn't even help for the CI errors seen in #738).
Edit: some sources regarding caching issues in pocl: pocl/pocl#430, pocl/pocl#466
There was a problem hiding this comment.
Before we go in this direction, I think we should engage with the pocl folks and least file an issue to see what they think about fixing concurrent access to their caches.
There was a problem hiding this comment.
Reported here: pocl/pocl#1480, including a small reproducer.
Co-authored-by: Matt Smith <mjsmith6@illinois.edu>
matthiasdiener
force-pushed
the
disable-build-cache-v2
branch
from
4ecc57c
to
4e2ab3e
Compare
Followup of #738