Reporting posts #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drusepth
commented
Aug 30, 2019
| @@ -30,6 +30,10 @@ module PostCommon | |||
| SELECT MAX(p2.created_at) from #{posts_table_name} p2 WHERE p2.postable_id = #{posts_table_name}.postable_id) | |||
| SQL | |||
| ) | |||
|
|
|||
| # When we can't load a preloader, return the results as-is | |||
| return result if preloader.empty? | |||
There was a problem hiding this comment.
I'm not yet sure what the preloaders are for or why we can no longer find them when a post has been reported. This is a hack that needs addressed.
This may be needed as of rails/rails@4f2ac80 Refs thredded#839
Use `combined_fragment_cache_key` instead of the older methods. This may be slightly slower but is easier to maintain going forward. Refs thredded#839
drusepth
force-pushed
the
feature/report-posts
branch
from
2dac881
to
b9a3976
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a placeholder PR just to collect all the code we've written to support reporting posts on Notebook.ai. Before an actual upstream PR, we'd want to rewrite all of this as a Thredded plugin.
AKA not to actually be merged.