ENH: adds first and last name to user and fix the tests

Co-authored-by: amanramoliya <70715941+amanramoliya@users.noreply.github.com>
incubyte · Sep 1, 2023 · cc34b2c · cc34b2c
1 parent 33fec01
commit cc34b2c
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 0 deletions.
diff --git a/backend/prisma/migrations/20230901055846_adding_name_for_the_user/migration.sql b/backend/prisma/migrations/20230901055846_adding_name_for_the_user/migration.sql
@@ -0,0 +1,3 @@
+-- AlterTable
+ALTER TABLE "User" ADD COLUMN     "firstName" TEXT,
+ADD COLUMN     "lastName" TEXT;
diff --git a/backend/prisma/schema.prisma b/backend/prisma/schema.prisma
@@ -15,6 +15,8 @@ enum Role {
 model User {
   id           String       @id @default(uuid())
   eId          String?      @unique
+  firstName    String?
+  lastName     String?
   role         String?
   clientTeam   String?
   projectTeam  String?

diff --git a/backend/src/auth/auth.controller.spec.ts b/backend/src/auth/auth.controller.spec.ts
@@ -48,6 +48,8 @@ describe('AuthController', () => {
       clientTeam: 'abc',
       roles: Role.Employee,
       projectTeam: 'abc',
+      firstName:"ABC",
+      lastName:"XYZ",
     });
     const result = await controller.signup(user);
     expect(service.signup).toBeCalledTimes(1);

diff --git a/backend/src/auth/auth.service.spec.ts b/backend/src/auth/auth.service.spec.ts
@@ -99,6 +99,8 @@ describe('AuthService', () => {
         role: 'BQA',
         clientTeam: 'abc',
         roles: Role.Employee,
+        firstName:"ABC",
+        lastName:"XYZ",
       });
       const result = await service.signup(userDTO);
       expect(prismaService.user.create).toBeCalledTimes(1);
@@ -136,6 +138,8 @@ describe('AuthService', () => {
         clientTeam: 'abc',
         roles: Role.Employee,
         projectTeam: 'abc',
+        firstName:"ABC",
+        lastName:"XYZ",
       };
 
       jest
@@ -167,6 +171,8 @@ describe('AuthService', () => {
         role: 'BQA',
         clientTeam: 'abc',
         roles: Role.Employee,
+        firstName:"ABC",
+        lastName:"XYZ",
       });
 
       jest
@@ -196,6 +202,8 @@ describe('AuthService', () => {
         role: 'BQA',
         clientTeam: 'abc',
         roles: Role.Employee,
+        firstName:"ABC",
+        lastName:"XYZ",
       });
 
       jest
@@ -231,6 +239,8 @@ describe('AuthService', () => {
         clientTeam: 'abc',
         roles: Role.Employee,
         projectTeam: 'abc',
+        firstName:"ABC",
+        lastName:"XYZ",
       });
 
       const mockResponse = {
@@ -263,6 +273,8 @@ describe('AuthService', () => {
         role: 'BQA',
         clientTeam: 'abc',
         roles: Role.Employee,
+        firstName:"ABC",
+        lastName:"XYZ",
       });
 
       const mockResponse = {
@@ -304,6 +316,8 @@ describe('AuthService', () => {
         role: 'BQA',
         clientTeam: 'abc',
         roles: Role.Employee,
+        firstName:"ABC",
+        lastName:"XYZ",
       };
 
       jest.spyOn(prismaService.user, 'update').mockResolvedValueOnce(mockUser);