Reduce libc mappings to really include what you use (part 3) #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mappings removed here are guaranteed by the relevant standards, but are not the canonical includes for the identifiers. To be strict with IWYU guidelines, remove those mappings, keeping only the canonical ones. Closes: <include-what-you-use#1531> Link: <include-what-you-use#1286> Link: <include-what-you-use#1278> Link: <include-what-you-use#1344> Link: <include-what-you-use#1283> Reported-by: Oliver Stöneberg <https://github.com/firewave> Cc: Kim Gräsman <kim.grasman@gmail.com> Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
This is the last step. |
alejandro-colomar
force-pushed
the
reduce
branch
3 times, most recently
from
fed2b45
to
6862a48
Compare
Signed-off-by: Alejandro Colomar <alx@kernel.org>
|
Can you please check the tests? I'm having a hard time making them work. :S |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mappings removed here are guaranteed by the relevant standards, but are not the canonical includes for the identifiers. To be strict with IWYU guidelines, remove those mappings, keeping only the canonical ones.
Closes: #1531