Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Remove same-file-overload-set logic completely #1529

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

RFC: Remove same-file-overload-set logic completely #1529

wants to merge 1 commit into from

Conversation

bolshakov-a
Copy link
Contributor

See discussion in #1525.

Besides, this fixes reporting ADL-found function declarations when all the non-ADL declarations are in a single file. The corresponding test case has been added to overload_expr.

Besides, this fixes #966, #792, #1335, and #1516.

@bolshakov-a
Remove same-file-overload-set logic completely
8bef29d 
See discussion in include-what-you-use#1525.

Besides, this fixes reporting ADL-found function declarations when all
the non-ADL declarations are in a single file. The corresponding test
case has been added to `overload_expr`.

Besides, this fixes include-what-you-use#966, include-what-you-use#792, include-what-you-use#1335, and include-what-you-use#1516.
@github-actions GitHub Actions
Copy link

Informational: IWYU dogfood results

include-what-you-use (exit: 0) 
# /home/runner/work/include-what-you-use/include-what-you-use/build/bin/include-what-you-use -Xiwyu --check_also=*/iwyu_port.h -Xiwyu --check_also=*/iwyu_stl_util.h -Xiwyu --check_also=*/iwyu_string_util.h -Xiwyu --check_also=*/iwyu_use_flags.h -Xiwyu --check_also=*/iwyu_version.h -DIWYU_GIT_REV="04bf363" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/lib/llvm-19/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -std=c++17 -fno-exceptions -funwind-tables -o CMakeFiles/include-what-you-use.dir/iwyu.cc.o -c /home/runner/work/include-what-you-use/include-what-you-use/iwyu.cc
# /home/runner/work/include-what-you-use/include-what-you-use/build/bin/include-what-you-use -Xiwyu --check_also=*/iwyu_port.h -Xiwyu --check_also=*/iwyu_stl_util.h -Xiwyu --check_also=*/iwyu_string_util.h -Xiwyu --check_also=*/iwyu_use_flags.h -Xiwyu --check_also=*/iwyu_version.h -DIWYU_GIT_REV="04bf363" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/lib/llvm-19/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -std=c++17 -fno-exceptions -funwind-tables -o CMakeFiles/include-what-you-use.dir/iwyu_ast_util.cc.o -c /home/runner/work/include-what-you-use/include-what-you-use/iwyu_ast_util.cc
# /home/runner/work/include-what-you-use/include-what-you-use/build/bin/include-what-you-use -Xiwyu --check_also=*/iwyu_port.h -Xiwyu --check_also=*/iwyu_stl_util.h -Xiwyu --check_also=*/iwyu_string_util.h -Xiwyu --check_also=*/iwyu_use_flags.h -Xiwyu --check_also=*/iwyu_version.h -DIWYU_GIT_REV="04bf363" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/lib/llvm-19/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -std=c++17 -fno-exceptions -funwind-tables -o CMakeFiles/include-what-you-use.dir/iwyu_cache.cc.o -c /home/runner/work/include-what-you-use/include-what-you-use/iwyu_cache.cc
# /home/runner/work/include-what-you-use/include-what-you-use/build/bin/include-what-you-use -Xiwyu --check_also=*/iwyu_port.h -Xiwyu --check_also=*/iwyu_stl_util.h -Xiwyu --check_also=*/iwyu_string_util.h -Xiwyu --check_also=*/iwyu_use_flags.h -Xiwyu --check_also=*/iwyu_version.h -DIWYU_GIT_REV="04bf363" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/lib/llvm-19/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -std=c++17 -fno-exceptions -funwind-tables -o CMakeFiles/include-what-you-use.dir/iwyu_driver.cc.o -c /home/runner/work/include-what-you-use/include-what-you-use/iwyu_driver.cc
# /home/runner/work/include-what-you-use/include-what-you-use/build/bin/include-what-you-use -Xiwyu --check_also=*/iwyu_port.h -Xiwyu --check_also=*/iwyu_stl_util.h -Xiwyu --check_also=*/iwyu_string_util.h -Xiwyu --check_also=*/iwyu_use_flags.h -Xiwyu --check_also=*/iwyu_version.h -DIWYU_GIT_REV="04bf363" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/lib/llvm-19/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -std=c++17 -fno-exceptions -funwind-tables -o CMakeFiles/include-what-you-use.dir/iwyu_getopt.cc.o -c /home/runner/work/include-what-you-use/include-what-you-use/iwyu_getopt.cc
# /home/runner/work/include-what-you-use/include-what-you-use/build/bin/include-what-you-use -Xiwyu --check_also=*/iwyu_port.h -Xiwyu --check_also=*/iwyu_stl_util.h -Xiwyu --check_also=*/iwyu_string_util.h -Xiwyu --check_also=*/iwyu_use_flags.h -Xiwyu --check_also=*/iwyu_version.h -DIWYU_GIT_REV="04bf363" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/lib/llvm-19/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -std=c++17 -fno-exceptions -funwind-tables -o CMakeFiles/include-what-you-use.dir/iwyu_globals.cc.o -c /home/runner/work/include-what-you-use/include-what-you-use/iwyu_globals.cc
# /home/runner/work/include-what-you-use/include-what-you-use/build/bin/include-what-you-use -Xiwyu --check_also=*/iwyu_port.h -Xiwyu --check_also=*/iwyu_stl_util.h -Xiwyu --check_also=*/iwyu_string_util.h -Xiwyu --check_also=*/iwyu_use_flags.h -Xiwyu --check_also=*/iwyu_version.h -DIWYU_GIT_REV="04bf363" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/lib/llvm-19/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -std=c++17 -fno-exceptions -funwind-tables -o CMakeFiles/include-what-you-use.dir/iwyu_include_picker.cc.o -c /home/runner/work/include-what-you-use/include-what-you-use/iwyu_include_picker.cc
# /home/runner/work/include-what-you-use/include-what-you-use/build/bin/include-what-you-use -Xiwyu --check_also=*/iwyu_port.h -Xiwyu --check_also=*/iwyu_stl_util.h -Xiwyu --check_also=*/iwyu_string_util.h -Xiwyu --check_also=*/iwyu_use_flags.h -Xiwyu --check_also=*/iwyu_version.h -DIWYU_GIT_REV="04bf363" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/lib/llvm-19/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -std=c++17 -fno-exceptions -funwind-tables -o CMakeFiles/include-what-you-use.dir/iwyu_lexer_utils.cc.o -c /home/runner/work/include-what-you-use/include-what-you-use/iwyu_lexer_utils.cc
# /home/runner/work/include-what-you-use/include-what-you-use/build/bin/include-what-you-use -Xiwyu --check_also=*/iwyu_port.h -Xiwyu --check_also=*/iwyu_stl_util.h -Xiwyu --check_also=*/iwyu_string_util.h -Xiwyu --check_also=*/iwyu_use_flags.h -Xiwyu --check_also=*/iwyu_version.h -DIWYU_GIT_REV="04bf363" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/lib/llvm-19/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -std=c++17 -fno-exceptions -funwind-tables -o CMakeFiles/include-what-you-use.dir/iwyu_location_util.cc.o -c /home/runner/work/include-what-you-use/include-what-you-use/iwyu_location_util.cc
# /home/runner/work/include-what-you-use/include-what-you-use/build/bin/include-what-you-use -Xiwyu --check_also=*/iwyu_port.h -Xiwyu --check_also=*/iwyu_stl_util.h -Xiwyu --check_also=*/iwyu_string_util.h -Xiwyu --check_also=*/iwyu_use_flags.h -Xiwyu --check_also=*/iwyu_version.h -DIWYU_GIT_REV="04bf363" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/lib/llvm-19/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -std=c++17 -fno-exceptions -funwind-tables -o CMakeFiles/include-what-you-use.dir/iwyu_output.cc.o -c /home/runner/work/include-what-you-use/include-what-you-use/iwyu_output.cc
# /home/runner/work/include-what-you-use/include-what-you-use/build/bin/include-what-you-use -Xiwyu --check_also=*/iwyu_port.h -Xiwyu --check_also=*/iwyu_stl_util.h -Xiwyu --check_also=*/iwyu_string_util.h -Xiwyu --check_also=*/iwyu_use_flags.h -Xiwyu --check_also=*/iwyu_version.h -DIWYU_GIT_REV="04bf363" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/lib/llvm-19/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -std=c++17 -fno-exceptions -funwind-tables -o CMakeFiles/include-what-you-use.dir/iwyu_path_util.cc.o -c /home/runner/work/include-what-you-use/include-what-you-use/iwyu_path_util.cc
# /home/runner/work/include-what-you-use/include-what-you-use/build/bin/include-what-you-use -Xiwyu --check_also=*/iwyu_port.h -Xiwyu --check_also=*/iwyu_stl_util.h -Xiwyu --check_also=*/iwyu_string_util.h -Xiwyu --check_also=*/iwyu_use_flags.h -Xiwyu --check_also=*/iwyu_version.h -DIWYU_GIT_REV="04bf363" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/lib/llvm-19/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -std=c++17 -fno-exceptions -funwind-tables -o CMakeFiles/include-what-you-use.dir/iwyu_port.cc.o -c /home/runner/work/include-what-you-use/include-what-you-use/iwyu_port.cc
# /home/runner/work/include-what-you-use/include-what-you-use/build/bin/include-what-you-use -Xiwyu --check_also=*/iwyu_port.h -Xiwyu --check_also=*/iwyu_stl_util.h -Xiwyu --check_also=*/iwyu_string_util.h -Xiwyu --check_also=*/iwyu_use_flags.h -Xiwyu --check_also=*/iwyu_version.h -DIWYU_GIT_REV="04bf363" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/lib/llvm-19/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -std=c++17 -fno-exceptions -funwind-tables -o CMakeFiles/include-what-you-use.dir/iwyu_preprocessor.cc.o -c /home/runner/work/include-what-you-use/include-what-you-use/iwyu_preprocessor.cc
# /home/runner/work/include-what-you-use/include-what-you-use/build/bin/include-what-you-use -Xiwyu --check_also=*/iwyu_port.h -Xiwyu --check_also=*/iwyu_stl_util.h -Xiwyu --check_also=*/iwyu_string_util.h -Xiwyu --check_also=*/iwyu_use_flags.h -Xiwyu --check_also=*/iwyu_version.h -DIWYU_GIT_REV="04bf363" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/lib/llvm-19/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -std=c++17 -fno-exceptions -funwind-tables -o CMakeFiles/include-what-you-use.dir/iwyu_regex.cc.o -c /home/runner/work/include-what-you-use/include-what-you-use/iwyu_regex.cc
# /home/runner/work/include-what-you-use/include-what-you-use/build/bin/include-what-you-use -Xiwyu --check_also=*/iwyu_port.h -Xiwyu --check_also=*/iwyu_stl_util.h -Xiwyu --check_also=*/iwyu_string_util.h -Xiwyu --check_also=*/iwyu_use_flags.h -Xiwyu --check_also=*/iwyu_version.h -DIWYU_GIT_REV="04bf363" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/usr/lib/llvm-19/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -std=c++17 -fno-exceptions -funwind-tables -o CMakeFiles/include-what-you-use.dir/iwyu_verrs.cc.o -c /home/runner/work/include-what-you-use/include-what-you-use/iwyu_verrs.cc

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_port.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_use_flags.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_stl_util.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu.cc has correct #includes/fwd-decls)


(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_ast_util.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_port.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_use_flags.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_stl_util.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_ast_util.cc has correct #includes/fwd-decls)


(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_cache.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_port.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_stl_util.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_use_flags.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_cache.cc has correct #includes/fwd-decls)


(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_driver.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_driver.cc has correct #includes/fwd-decls)


(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_getopt.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_getopt.cc has correct #includes/fwd-decls)


(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_globals.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_port.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_stl_util.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_string_util.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_version.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_globals.cc has correct #includes/fwd-decls)


(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_include_picker.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_port.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_stl_util.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_string_util.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_include_picker.cc has correct #includes/fwd-decls)


(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_lexer_utils.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_port.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_lexer_utils.cc has correct #includes/fwd-decls)


(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_location_util.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_port.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_use_flags.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_string_util.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_location_util.cc has correct #includes/fwd-decls)


(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_output.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_port.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_stl_util.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_use_flags.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_string_util.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_output.cc has correct #includes/fwd-decls)


(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_path_util.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_port.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_string_util.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_path_util.cc has correct #includes/fwd-decls)


(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_port.cc has correct #includes/fwd-decls)

/home/runner/work/include-what-you-use/include-what-you-use/iwyu_preprocessor.cc:393:49: warning: @headername directive missing a closing brace

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_preprocessor.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_port.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_stl_util.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_use_flags.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_string_util.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_preprocessor.cc has correct #includes/fwd-decls)


(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_regex.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_port.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_string_util.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_regex.cc has correct #includes/fwd-decls)


(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_verrs.h has correct #includes/fwd-decls)

(/home/runner/work/include-what-you-use/include-what-you-use/iwyu_verrs.cc has correct #includes/fwd-decls)
fix_includes.py (exit: 0) 
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_port.h: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_use_flags.h: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_stl_util.h: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu.cc: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_ast_util.h: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_ast_util.cc: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_cache.h: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_cache.cc: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_driver.h: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_driver.cc: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_getopt.h: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_getopt.cc: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_globals.h: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_string_util.h: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_version.h: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_globals.cc: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_include_picker.h: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_include_picker.cc: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_lexer_utils.h: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_lexer_utils.cc: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_location_util.h: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_location_util.cc: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_output.h: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_output.cc: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_path_util.h: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_path_util.cc: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_port.cc: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_preprocessor.h: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_preprocessor.cc: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_regex.h: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_regex.cc: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_verrs.h: iwyu reports no contentful changes)
(skipping /home/runner/work/include-what-you-use/include-what-you-use/iwyu_verrs.cc: iwyu reports no contentful changes)
IWYU edited 0 files on your behalf.
diff 



      		
    

  





        


            

              
            

        

      


      

            
  

    
  
  

  

  



    












      

  
          

  

    
  


  

      

    @bolshakov-a
bolshakov-a



    mentioned this pull request
    
      Apr 23, 2024
    





  


  

      
  
  Open

  







  













  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    

    
  

    Reviewers
  


    

    No reviews






    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

    None yet







      

  

    

        

    Projects
  


        




    None yet




  



      

  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.


  
    
            
        iwyu removes include required by variable template specialization 





    
  




        
      

    

  
      

  

    

      1 participant
    

    

        
          @bolshakov-a