Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a character counter to the tweet msg in the Tweet to Download template #83

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

daprela
Copy link
Contributor

@daprela daprela commented Feb 15, 2015

This function add a character counter in the Tweet message editor so that people can know when they reach the 120 charachters allowed in their message.
To get to this, I decided to add a jQuery function to the library, enqueue it, and call this function from the config.php file that is loaded when the tweet to download template is used.

@atwellpub
Copy link
Member

Hey awesome for following up on this. In order to include it we'll need to move the library file you added here daprela/cta@b835984 out of /cta/js/ and into cta/templates/tweet-to-download/js/ and also enqueue it from config.php like you did with the admin_print_footer_scripts hook.

That way the entire mod will be encapsulated in config.php and will also help train template builders who to make modificiations contained within the template folder.

Does that make sense?

@daprela
Copy link
Contributor Author

daprela commented Feb 16, 2015

Absolutely, I understand what you want to do, and it makes sense to me. Do you want me to take care of this change?

@atwellpub
Copy link
Member

Might as well so it's 100% yours.

@daprela
Copy link
Contributor Author

daprela commented Feb 16, 2015

Ok no problem, I'll do it. I'll have to open a new pull request when I've finished?

@atwellpub
Copy link
Member

I don't think so. I think the commits will add to the already open pull request automatically. I'm not positive though, yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants