-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing unit-test #3806
base: develop
Are you sure you want to change the base?
Fix failing unit-test #3806
Conversation
Is this finished @myarjunar ? I don't see which test is un-skipped. |
@ismailsunni two tests are un-skipped. Can we park this PR a little bit ? These two tests are going to impacted later today maybe by me. I guess there is some others expectedFailure or skip in the code. |
Ah shame, I didn't see it properly. I am fine to park it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think I merged a population data in the mean time. I think you should use this one now if we can |
@Gustry which data sorry? |
I think we put some population data already. We need to fix the dataset included in this PR. You put a new flood hazard layer with amenity=hospital, amenity=school ... Exposure and hazard can't be mixed. |
@myarjunar Sorry I merged my other PR related to one failing test. |
see Update Unit Test in InaSAFE #3723