Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing unit-test #3806

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix failing unit-test #3806

wants to merge 4 commits into from

Conversation

myarjunar
Copy link
Collaborator

@myarjunar myarjunar commented Feb 9, 2017

@ismailsunni
Copy link
Member

Is this finished @myarjunar ? I don't see which test is un-skipped.

@Gustry
Copy link
Contributor

Gustry commented Feb 10, 2017

@ismailsunni two tests are un-skipped. Can we park this PR a little bit ? These two tests are going to impacted later today maybe by me.

I guess there is some others expectedFailure or skip in the code.
Can you quickly make a list on #2977 ?

@ismailsunni
Copy link
Member

Ah shame, I didn't see it properly.

I am fine to park it :)

Copy link
Contributor

@timlinux timlinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gustry
Copy link
Contributor

Gustry commented Feb 27, 2017

I think I merged a population data in the mean time. I think you should use this one now if we can

@myarjunar
Copy link
Collaborator Author

@Gustry which data sorry?

@Gustry
Copy link
Contributor

Gustry commented Feb 27, 2017

@Gustry which data sorry?

I think we put some population data already.

We need to fix the dataset included in this PR. You put a new flood hazard layer with amenity=hospital, amenity=school ... Exposure and hazard can't be mixed.
And we try to keep gisv4 with very small layers where results are nearly predictable. Do we need these layers ?

@Gustry
Copy link
Contributor

Gustry commented Feb 27, 2017

@myarjunar Sorry I merged my other PR related to one failing test.
I think we still need to hold on for these tests.
But there are some others failing tests : #2977

@timlinux timlinux added this to the InaSAFE 4.2 milestone Jun 8, 2017
@timlinux timlinux modified the milestones: InaSAFE 4.3, InaSAFE 4.2 Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants