identify cleavage segmentation #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoxusci
commented
Jul 15, 2021
haoxusci
commented
- assign unique ids to cleaved circles
|
✔️ Deploy Preview for kaibu ready! 🔨 Explore the source changes: 23dad04 🔍 Inspect the deploy log: https://app.netlify.com/sites/kaibu/deploys/60f154390ca11500083f9810 😎 Browse the preview: https://deploy-preview-68--kaibu.netlify.app/ |
oeway
reviewed
Jul 16, 2021
| @@ -274,8 +274,14 @@ function polygonCut(polygon, line, properties) { | |||
| } | |||
| } | |||
|
|
|||
| properties['id'] = new Date().getTime() | |||
There was a problem hiding this comment.
What if the ROI already have an id?
There was a problem hiding this comment.
Id should be a string, not integer, right?
There was a problem hiding this comment.
resolved, with using randId() func
| cutFeatures.push(turf.polygon(geometry, properties)); | ||
| if (Object.keys(properties).includes('id')){ | ||
| properties['id'] = properties['id'] + 1 | ||
| console.log(JSON.stringify(properties['id'])) |
There was a problem hiding this comment.
Remove console message after testing.
| cutPolyGeoms.forEach(function(geometry) { | ||
| cutFeatures.push(turf.polygon(geometry, properties)); | ||
| if (Object.keys(properties).includes('id')){ | ||
| properties['id'] = properties['id'] + 1 |
There was a problem hiding this comment.
- +1 doesn't seem to make it unique, maybe better to call 'randId()' to generate a suffix.
There was a problem hiding this comment.
randId() is used to generate the ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.