Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating secrets for Heroku automatically #369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bmann
Copy link

@bmann bmann commented Apr 1, 2020

Your deploy to heroku wasn't using the generator: secret. I added that to app.json, and it now does deploy automatically with the secrets filled in.

@DarthSim
Copy link
Member

DarthSim commented Apr 1, 2020

Hi,
IMGPROXY_KEY and IMGPROXY_SALT should be hex-encoded. The documentation says the following:

Currently the only supported generator is secret, which generates a pseudo-random string of characters.

A pseudo-random string would most probably not be a hex-encoding compatible one.

@bmann
Copy link
Author

bmann commented Apr 1, 2020

@DarthSim I installed it and it worked using this 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants