Add latency in nanoseconds as a response log field #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarthSim
requested changes
Mar 21, 2024
| @@ -33,12 +34,15 @@ func LogResponse(reqID string, r *http.Request, status int, err *ierrors.Error, | |||
| } | |||
|
|
|||
| clientIP, _, _ := net.SplitHostPort(r.RemoteAddr) | |||
| ctxDuration := ctxTime(r.Context()) | |||
| latency := strconv.FormatInt(int64(ctxDuration), 10) | |||
There was a problem hiding this comment.
There's no need to stringify ctxDuration, logrus works well with numbers.
Also, this will return the duration in nanoseconds which I see a little bit redundant. I believe millisecond precision should be enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the latency of a request as a response log field. This is useful when filtering logs in Google Cloud logging for requests that have high latencies.