Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change lodash to lodash.memoize #120

Closed
wants to merge 1 commit into from

Conversation

vanling
Copy link

@vanling vanling commented May 11, 2024

fix: #78

I still had a problem with loading the node lib on Nuxt3 (server) I believe this is the way to fix that issue where the dependency could not be found.

My knowledge of npm with multiple packages like this is minimal, so I hope i did this right

@vanling
Copy link
Author

vanling commented May 11, 2024

Maybe this only happened when i tried to use the web version. ( I might close this soon)

Update: ok, so this missing memoize/lodash only happened when using the browser version in nuxt, the node version worked. ( i think i messed up by switching in between.)

Leaving this open to hear your thoughts, might stil be a good change to only import the memoize function instead of the whole lib

@DanielHauschildt
Copy link
Contributor

Is it still a problem in 1.5 that was released last week? The issue you are referring to was already solved before. It might be a regression though.

@vanling
Copy link
Author

vanling commented May 16, 2024

So it happened only with the 'browser version', node version works ok in Nuxt/server.
I will take another look tomorrow with the browser version in Nuxt/frontend.

@vanling
Copy link
Author

vanling commented May 17, 2024

@DanielHauschildt closing, can not reproduce on browser or server. I guess I mixed up node and browser version the last time.

@vanling vanling closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants