Fix SeekableFileObject does not have readline when loading HTTP file
#1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The change looks good ... just the test image is unlicensed, so we will have to find an alternative (again ._.).
@Pandede do you know what causes Pillow to use readline vs read? If so, we can probably generate an artificial test image and use it for the test here.
There also is an issue with CI right now. Github has switched Mac runners to M1 and some of our old plugins don't support that. I'm looking currently looking into a fix and will let you know once it's in master so we can run the test suite again.
|
I may reproduce the bug with this test image of |
FirefoxMetzger
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1065.
The reason of this issue is
Pillowsometimes read the image with.readlinebut not only.read.Update:
It happens seldomly when loading a WebP image.